Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue severity subgroup pre-TPAC content #656

Merged
merged 5 commits into from
Nov 10, 2022

Conversation

fstrr
Copy link
Contributor

@fstrr fstrr commented Sep 5, 2022

Initial PR for the Issue Severity subgroup. Added content to describe our work to date and also what needs to happen next. Also added examples of critical failures to functional images and text equivalent outcomes.

Copy link

@cwadamsoforacle cwadamsoforacle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the 3 files in this PR, and do not have any changes to recommend. I approve of these.

Copy link

@cwadamsoforacle cwadamsoforacle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

@michael-n-cooper michael-n-cooper merged commit f68e440 into main Nov 10, 2022
github-actions bot added a commit that referenced this pull request Nov 10, 2022
SHA: f68e440
Reason: push, by michael-n-cooper

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@shawnthompson
Copy link

@rachaelbradley Why were these changes removed?

cc/ @fstrr, @gradualclearing, @alastc

@alastc
Copy link
Contributor

alastc commented Nov 30, 2022

Why were these changes removed?

This branch was merged, only sub-group members edited it (from the links above), I'm not sure what you mean was removed?

@shawnthompson
Copy link

Our changes are no long in the editor's draft.

They were removed in this commit 0bde7a7

@rachaelbradley is adding them back in this PR: Move issue severity work into main guidelines document #661.

Although the expected results additions are not being added back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants